ipa-replica-manage: fix force-sync #2925
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipa-replica-manage force-sync --from <server> is performing a wrong check that may result in the tool looping on "No status yet". force-sync is adding a nsds5replicaupdateschedule attribute to the replication agreement in order to force replication to wake up. Note that this is not a re-initialization (re init drops the current db and reloads the entire db). In a second step, force-sync is checking the replication agreement by reading nsds5BeginReplicaRefresh, nsds5ReplicaLastInitStatus, nsds5ReplicaLastInitStart and nsds5ReplicaLastInitEnd. This is a wrong test as force-sync is not an init operation and does not touch these attributes. The tool should call wait_for_repl_update rather than wait_for_repl_init. This way, the check is done on the replication agreement attributes nsds5replicaUpdateInProgress, nsds5ReplicaLastUpdateStatus, nsds5ReplicaLastUpdateStart and nsds5ReplicaLastUpdateEnd. Fixes: https://pagure.io/freeipa/issue/7886
flo-renaud
added
needs review
tiran
added
ack
tiran
approved these changes
Mar 25, 2019
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipa-replica-manage force-sync --from is performing a wrong check
that may result in the tool looping on "No status yet".
force-sync is adding a nsds5replicaupdateschedule attribute to the
replication agreement in order to force replication to wake up. Note that
this is not a re-initialization (re init drops the current db and reloads
the entire db).
In a second step, force-sync is checking the replication agreement by reading
nsds5BeginReplicaRefresh, nsds5ReplicaLastInitStatus,
nsds5ReplicaLastInitStart and nsds5ReplicaLastInitEnd. This is a wrong
test as force-sync is not an init operation and does not touch these
attributes.
The tool should call wait_for_repl_update rather than wait_for_repl_init.
This way, the check is done on the replication agreement attributes
nsds5replicaUpdateInProgress, nsds5ReplicaLastUpdateStatus,
nsds5ReplicaLastUpdateStart and nsds5ReplicaLastUpdateEnd.
Fixes: https://pagure.io/freeipa/issue/7886