ipa-setup-kra: fix python2 parameter #2968
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipa-setup-kra is failing in python2 with invalid 'role_servrole': must be Unicode text because of a unicode conversion error. The method api.Command.server_role_find is called with the parameter role_servrole='IPA master' but it should rather be role_servrole=u'IPA master' Fixes: https://pagure.io/freeipa/issue/7897
tiran
approved these changes
Apr 1, 2019
tiran
added
ack
|
Thanks for the fix! Note: The patch is only required for Python 2 compatibility on RHEL 7. The master branch no longer supports Python 2. It doesn't hurt to have the change in master, though. |
tiran
added
prioritized
|
master:
|
This was referenced Apr 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipa-setup-kra is failing in python2 with
invalid 'role_servrole': must be Unicode text
because of a unicode conversion error.
The method api.Command.server_role_find is called with the parameter
role_servrole='IPA master' but it should rather be
role_servrole=u'IPA master'
Fixes: https://pagure.io/freeipa/issue/7897