Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-6] Fix uninstallation test, use different method to stop dirsrv #2981

Closed

Conversation

flo-renaud
Copy link
Contributor

This is a manual backport of PR #2266.
I cherry-picked only the first commit: 2064c72 Fix uninstallation test, use different method to stop dirsrv
and left out 11b3cdf Add uninstallation tests to night master and rawhide
because there is currently no nightly tests on ipa-4-6 branch

The API may not be initialized so using ds.is_running() may fail.
Call systemctl directly to ensure the dirsrv instance is stopped.

Signed-off-by: Rob Crittenden <rcritten@redhat.com>
Reviewed-By: Christian Heimes <cheimes@redhat.com>
Reviewed-By: Florence Blanc-Renaud <frenaud@redhat.com>
Reviewed-By: Michal Reznik <mreznik@redhat.com>
@flo-renaud
Copy link
Contributor Author

ACKing as it's a simple backport, please wait for PRCI to finish before pushing.

@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Apr 2, 2019
@flo-renaud
Copy link
Contributor Author

ipa-4-6:

  • 19cbd37 Fix uninstallation test, use different method to stop dirsrv

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Apr 3, 2019
@flo-renaud flo-renaud closed this Apr 3, 2019
@flo-renaud flo-renaud deleted the backport_pr2266_ipa-4-6 branch April 11, 2019 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants