Move DS's Kerberos env vars to unit file #2982
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
changed the title
abbra
requested changes
Apr 2, 2019
config_replace_variables() can now also remove lines from a file. Related: https://pagure.io/freeipa/issue/7860 Signed-off-by: Christian Heimes <cheimes@redhat.com>
systemd daemon must be reloaded after a config file is added, changed, or removed. Provide a common API endpoint in ipaplatform.tasks. Related: https://pagure.io/freeipa/issue/7860 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
issue7860-ds-sysconfig
branch
from
c148289
to
1043089
Compare
|
tiran
force-pushed
the
issue7860-ds-sysconfig
branch
from
1043089
to
9ed57cd
Compare
The IPA specific env vars KRB5_KTNAME and KRB5CCNAME are now defined in a instance specific ipa-env.conf unit file. Fixes: https://pagure.io/freeipa/issue/7860 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
issue7860-ds-sysconfig
branch
from
9ed57cd
to
48c7bf9
Compare
tiran
added
needs review
abbra
approved these changes
Apr 2, 2019
|
LGTM. I'll wait for the remaining CI test before adding labels. |
abbra
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The IPA specific env vars KRB5_KTNAME and KRB5CCNAME are now defined in a instance specific ipa-env.conf unit file.
Fixes: https://pagure.io/freeipa/issue/7860