Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ipa-4-6] Create nightly test definition #2993

Closed
wants to merge 2 commits into from

Conversation

flo-renaud
Copy link
Contributor

PRCI: add nightly definition for ipa-4-6 branch

Replace .freeipa-pr-ci.yaml with a link to ipatests/prci_definitions/gating.yaml
Create a nightly test definition

tests: fix test_user_permissions.py::TestInstallClientNoAdmin

Adapt the test to ipa-4-6 branch. On this branch, the calls to external commands are logged with
---8<---
Starting external process
args=/usr/bin/getent passwd testuser1@domain.com
---8<---

while on master branch the logs are
---8<---
Starting external process
args=['/usr/bin/getent', 'passwd', 'testuser1@domain.com']
---8<---

This is because 9c2c3df was not backported to ipa-4-6 branch and modified the debug logs when calling ipautil.run()

Replace .freeipa-pr-ci.yaml with a link to ipatests/prci_definitions/gating.yaml
Create a nightly test definition
Adapt the test to ipa-4-6 branch. On this branch, the calls to external
commands are logged with
---8<---
Starting external process
args=/usr/bin/getent passwd testuser1@domain.com
---8<---

while on master branch the logs are
---8<---
Starting external process
args=['/usr/bin/getent', 'passwd', 'testuser1@domain.com']
---8<---

This is because 9c2c3df was not backported to ipa-4-6 branch and modified
the debug logs when calling ipautil.run()
@flo-renaud
Copy link
Contributor Author

Note: I didn't add all the tests defined in the master branch as

  • some were not backported to ipa-4-6
  • some are failing and need to be fixed first (test_server_del.py, test_replication_layouts.py, test_uninstallation.py)

You can see a successful run of the nightly tests at freeipa-pr-ci2#9 if you click on the green tick.

@tiran
Copy link
Member

tiran commented Apr 4, 2019

@flo-renaud The list of successful nightly tests is no longer available. GH hides the results as soon as a PR is closed.

@flo-renaud
Copy link
Contributor Author

nightly_results

@tiran If you click on the green tick you should be able to see the result

@flo-renaud
Copy link
Contributor Author

@f-trivino Could you check if this PR is consistent with the nightly jobs we define on other branches? For instance I named the nightly test def nightly_ipa-4-6.yaml. Thanks

@flo-renaud flo-renaud added the needs review Pull Request is waiting for a review label Apr 4, 2019
@netoarmando
Copy link
Member

@flo-renaud for ipa-4-7 test definitions file is named nightly_master.yaml, but I have to say that naming it nightly_ipa-4-6.yaml for this branch makes more sense. I think we can apply this to ipa-4-7 later.

@f-trivino
Copy link
Contributor

LGTM!, I have review that the topologies are correct and the ci-ipa-4-6 template is the latest that we have: v1.0.1. Looks good to me. Let's get it merged.

@f-trivino f-trivino added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Apr 9, 2019
@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Apr 10, 2019
@flo-renaud
Copy link
Contributor Author

ipa-4-6:

  • a0014db PRCI: add nightly definition for ipa-4-6 branch
  • 5ca8b4f tests: fix test_user_permissions.py::TestInstallClientNoAdmin

@flo-renaud flo-renaud closed this Apr 10, 2019
@flo-renaud flo-renaud deleted the nightly46 branch April 29, 2019 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants