Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport ipa-4-6] Bypass D-BUS interface definition deficiences for trust-fetch-domains #3008

Closed
wants to merge 1 commit into from

Commits on Apr 8, 2019

  1. Bypass D-BUS interface definition deficiences for trust-fetch-domains

    In oddjobd it is possible to pass arguments as command line or on the
    stdin. We use command line to pass them but the way oddjobd registers
    the D-BUS method signatures is by specifying all arguments as mandatory.
    
    Internally, oddjobd simply ignores if you passed less arguments than
    specified in the D-BUS defition. Unfortunately, it is not possible to
    specify less than maximum due to D-BUS seeing all arguments in the
    list (30 is defined for the trust-fetch-domains).
    
    To pass options, have to pad a list of arguments to maximum with empty
    strings and then filter out unneeded ones in the script. Option parser
    already removes all options from the list of arguments so all we need to
    do is to take our actual arguments. In case of trust-fetch-domains, it
    is the name of the domain so we can only care about args[0].
    
    Fixes: https://pagure.io/freeipa/issue/7903
    Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
    (cherry picked from commit add6180)
    abbra committed Apr 8, 2019
    Configuration menu
    Copy the full SHA
    37e2ffc View commit details
    Browse the repository at this point in the history