[Backport][ipa-4-7] ipa-backup: better error message if ENOSPC #3120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the destination directory cannot store the complete backup ipa-backup fails but does not explain why. This commit adds error-checking to db2ldif(), db2bak() and finalize_backup() and enhances the error message. Fixes: https://pagure.io/freeipa/issue/7647 Signed-off-by: François Cami <fcami@redhat.com> Reviewed-By: Florence Blanc-Renaud <flo@redhat.com> Reviewed-By: Tibor Dudlák <tdudlak@redhat.com> Reviewed-By: Christian Heimes <cheimes@redhat.com> Reviewed-By: Thomas Woerner <twoerner@redhat.com>
fcami
added
ack
|
ipa-4-7:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MANUAL BACKPORT WITH NO CHANGE
When the destination directory cannot store the complete backup
ipa-backup fails but does not explain why.
This commit adds error-checking to db2ldif(), db2bak() and
finalize_backup() and enhances the error message.
Fixes: https://pagure.io/freeipa/issue/7647
Signed-off-by: François Cami fcami@redhat.com
Reviewed-By: Florence Blanc-Renaud flo@redhat.com
Reviewed-By: Tibor Dudlák tdudlak@redhat.com
Reviewed-By: Christian Heimes cheimes@redhat.com
Reviewed-By: Thomas Woerner twoerner@redhat.com