Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build_requestinfo in LibreSSL environments #3141

Closed
wants to merge 1 commit into from
Closed

Fix build_requestinfo in LibreSSL environments #3141

wants to merge 1 commit into from

Conversation

stanislavlevin
Copy link
Contributor

@stanislavlevin stanislavlevin commented May 13, 2019 •
edited

build_requestinfo was broken in ac6568d.
In this case LibreSSL behavior is the same as OpenSSL < 1.1.x.
Thus, an additional check for SSL implementation was added.

Fixes: https://pagure.io/freeipa/issue/7937

@stanislavlevin
Fix build_requestinfo in LibreSSL environments
5a39570 
`build_requestinfo` was broken in @ac6568dcf.
In this case LibreSSL behavior is the same as OpenSSL < 1.1.x.
Thus, an additional check for SSL implementation was added.

Fixes: https://pagure.io/freeipa/issue/7937
Signed-off-by: Stanislav Levin <slev@altlinux.org>
tiran
tiran approved these changes May 13, 2019
View reviewed changes
Copy link
Member

@tiran tiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

By the way, how did you discover the problem? Are we missing an automated test that utilizes the code path?

@stanislavlevin
Copy link
Contributor Author

One of my tasks is the setup of the IPA CI for my distro.
I'm going to start from tests (make fasttest) during RPM build ( every day running ).

The very first fail I faced is this issue :-)
Actually, test_ipaclient/test_csrgen.py::test_CSRGenerator::test_works_with_lowercase_attr_type_shortname catches excellent (crashes).

To sum up, I checked this PR locally with:

  • OpenSSL-1.1.1b
  • OpenSSL-1.0.2r
  • LibreSSL-2.9.1
  • LibreSSL-2.6.4

@tiran
Copy link
Member

tiran commented May 14, 2019

I found the reason why our tests never crashed, see https://pagure.io/freeipa/issue/7947

@tiran tiran added ack Pull Request approved, can be merged ipa-4-7 re-run Trigger a new run of PR-CI labels May 14, 2019
@freeipa-pr-ci freeipa-pr-ci removed re-run Trigger a new run of PR-CI labels May 14, 2019
@tiran tiran added the re-run Trigger a new run of PR-CI label May 14, 2019
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label May 14, 2019
@tiran tiran added the pushed Pull Request has already been pushed label May 14, 2019
@tiran
Copy link
Member

tiran commented May 14, 2019

master:

  • 7b8a2af Fix build_requestinfo in LibreSSL environments

@tiran tiran closed this May 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiran tiran tiran approved these changes

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@stanislavlevin @tiran @freeipa-pr-ci