Exit on fail in azure multiline script #3280
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, the `last` exit code returned from Azure script will be checked and, if non-zero, treated as a step failure. Luckily, for Linux script is a shortcut for Bash. Hence errexit/e option could be applied. But Azure pipelines doesn't set it by default: microsoft/azure-pipelines-agent#1803 For multiline script this is a problem, unless otherwise designed. Some of benefits of checking the result of each subcommand: - preventing subsequent issues (broken packages, container images, etc.) - time saving (next steps will not run) - good diagnostics (tells which part of script fails) Signed-off-by: Stanislav Levin <slev@altlinux.org>
abbra
added
ack
|
LGTM. |
|
Let us run full test too. |
|
master:
|
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, the
lastexit code returned from Azure script will bechecked and, if non-zero, treated as a step failure. Luckily,
for Linux script is a shortcut for Bash. Hence errexit/e option
could be applied. But Azure pipelines doesn't set it by default:
microsoft/azure-pipelines-agent#1803
For multiline script this is a problem unless otherwise designed.
Some of the benefits of checking the result of each subcommand: