New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't configure disabled krb5 enctypes in FIPS mode #3357
Conversation
The only permitted ciphers are the AES family (called aes, which is the combination of: aes256-cts-hmac-sha1-96, aes128-cts-hmac-sha1-96, aes256-cts-hmac-sha384-192, and aes128-cts-hmac-sha256-128). DES, RC4, and Camellia are not permitted in FIPS mode. While 3DES is permitted, the KDF used for it in krb5 is not, and Microsoft doesn't implement 3DES anyway. This is only applied on new installations because we don't allow converting a non-FIPS install into a FIPS one.
Looks good. Since we have SMB test in the gating set now, I wonder if we can simply disable all outdated ciphers (except camelia in non-FIPS) completely and try PR CI? If test_smb test would pass, that means we don't really need to enable all those. |
These are already marked as deprecated by the KDC.
Pushed a second patch on to completely remove 3DES and RC4. We'll see what happens. |
This exercises the removal of 3DES and RC4 via Samba.
Well, I'm excited by that second commit; hopefully it doesn't break any trust stuff. (3DES should be fine; it's gone in Fedora anyway.) |
@frozencemetery to have it fully working in FIPS mode, I suspect we'd need your help in krb5 to allow creating I'm not sure krb5 in Fedora has this enablement for non crypto use. |
It doesn't, but I can make it appear, provided the test build I gave you worked. (If this is hard to check, let me know - I can just apply to rawhide and revert if needed.) |
The only permitted ciphers are the AES family (called aes, which
is the combination of: aes256-cts-hmac-sha1-96,
aes128-cts-hmac-sha1-96, aes256-cts-hmac-sha384-192, and
aes128-cts-hmac-sha256-128).
DES, RC4, and Camellia are not permitted in FIPS mode. While 3DES
is permitted, the KDF used for it in krb5 is not, and Microsoft
doesn't implement 3DES anyway.
This is only applied on new installations because we don't
allow converting a non-FIPS install into a FIPS one.