Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't configure disabled krb5 enctypes in FIPS mode #3357

Closed
wants to merge 3 commits into from

Conversation

rcritten
Copy link
Contributor

@rcritten rcritten commented Jul 1, 2019

The only permitted ciphers are the AES family (called aes, which
is the combination of: aes256-cts-hmac-sha1-96,
aes128-cts-hmac-sha1-96, aes256-cts-hmac-sha384-192, and
aes128-cts-hmac-sha256-128).

DES, RC4, and Camellia are not permitted in FIPS mode. While 3DES
is permitted, the KDF used for it in krb5 is not, and Microsoft
doesn't implement 3DES anyway.

This is only applied on new installations because we don't
allow converting a non-FIPS install into a FIPS one.

The only permitted ciphers are the AES family (called aes, which
is the combination of: aes256-cts-hmac-sha1-96,
aes128-cts-hmac-sha1-96, aes256-cts-hmac-sha384-192, and
aes128-cts-hmac-sha256-128).

DES, RC4, and Camellia are not permitted in FIPS mode.  While 3DES
is permitted, the KDF used for it in krb5 is not, and Microsoft
doesn't implement 3DES anyway.

This is only applied on new installations because we don't
allow converting a non-FIPS install into a FIPS one.
@rcritten rcritten added the ipa-next Mark as master (4.12) only label Jul 1, 2019
@abbra
Copy link
Contributor

abbra commented Jul 1, 2019

Looks good. Since we have SMB test in the gating set now, I wonder if we can simply disable all outdated ciphers (except camelia in non-FIPS) completely and try PR CI? If test_smb test would pass, that means we don't really need to enable all those.

These are already marked as deprecated by the KDC.
@rcritten
Copy link
Contributor Author

rcritten commented Jul 1, 2019

Pushed a second patch on to completely remove 3DES and RC4. We'll see what happens.

@rcritten rcritten closed this Jul 1, 2019
@rcritten rcritten reopened this Jul 1, 2019
This exercises the removal of 3DES and RC4 via Samba.
@frozencemetery
Copy link
Contributor

Well, I'm excited by that second commit; hopefully it doesn't break any trust stuff. (3DES should be fine; it's gone in Fedora anyway.)

@abbra
Copy link
Contributor

abbra commented Jul 1, 2019

@frozencemetery to have it fully working in FIPS mode, I suspect we'd need your help in krb5 to allow creating krb5_c_string_to_key() to accept arcfour-hmac (krb5_c_string_to_key() will use EVP_md4() in openssl backend in FIPS mode and will be blocked from using it).

I'm not sure krb5 in Fedora has this enablement for non crypto use.

@abbra abbra added the re-run Trigger a new run of PR-CI label Jul 1, 2019
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 1, 2019
@abbra abbra added ack Pull Request approved, can be merged re-run Trigger a new run of PR-CI labels Jul 1, 2019
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 1, 2019
@frozencemetery
Copy link
Contributor

frozencemetery commented Jul 1, 2019

It doesn't, but I can make it appear, provided the test build I gave you worked. (If this is hard to check, let me know - I can just apply to rawhide and revert if needed.)

@abbra
Copy link
Contributor

abbra commented Jul 2, 2019

master:

  • a43100b Don't configure disabled krb5 enctypes in FIPS mode
  • dd9fd09 Remove DES3 and RC4 enctypes from Kerberos
  • 258cacb Add test_smb to night Fedora 30 test suite

@abbra abbra added the pushed Pull Request has already been pushed label Jul 2, 2019
@abbra abbra closed this Jul 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-next Mark as master (4.12) only pushed Pull Request has already been pushed
Projects
None yet
4 participants