Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][ipa-4-6] Updated PR 3542 with a test #3557

Closed
wants to merge 2 commits into from
Closed

[Backport][ipa-4-6] Updated PR 3542 with a test #3557

wants to merge 2 commits into from

Conversation

abbra
Copy link
Contributor

@abbra abbra commented Aug 19, 2019

This PR was opened automatically because PR #3554 was pushed to master and backport to ipa-4-6 is required.

sumit-bose and others added 2 commits August 19, 2019 11:20
@sumit-bose @abbra
extdom: unify error code handling especially LDAP_NO_SUCH_OBJECT
a87f5ec 
A return code LDAP_NO_SUCH_OBJECT will tell SSSD on the IPA client to
remove the searched object from the cache. As a consequence
LDAP_NO_SUCH_OBJECT should only be returned if the object really does
not exists otherwise the data of existing objects might be removed form
the cache of the clients causing unexpected behaviour like
authentication errors.

Currently some code-paths use LDAP_NO_SUCH_OBJECT as default error code.
With this patch LDAP_NO_SUCH_OBJECT is only returned if the related
lookup functions return ENOENT. Timeout related error code will lead to
LDAP_TIMELIMIT_EXCEEDED and LDAP_OPERATIONS_ERROR is used as default
error code.

Fixes: https://pagure.io/freeipa/issue/8044
@abbra
ipa-extdom-extop: test timed out getgrgid_r
49c94a4 
Simulate getgrgid_r() timeout when packing list of groups user is a
member of in pack_ber_user().

Related: https://pagure.io/freeipa/issue/8044
@abbra abbra added the ack Pull Request approved, can be merged label Aug 19, 2019
@abbra
Copy link
Contributor Author

abbra commented Aug 19, 2019

PR was ACKed automatically because this is backport of PR #3554. Wait for CI to finish before pushing. In case of questions or problems contact @abbra who is author of the original PR.

@abbra abbra added the re-run Trigger a new run of PR-CI label Aug 19, 2019
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Aug 19, 2019
@abbra abbra added the pushed Pull Request has already been pushed label Aug 19, 2019
@abbra
Copy link
Contributor Author

abbra commented Aug 19, 2019

ipa-4-6:

  • 574a615 extdom: unify error code handling especially LDAP_NO_SUCH_OBJECT
  • 387ed98 ipa-extdom-extop: test timed out getgrgid_r

@abbra abbra closed this Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@abbra @freeipa-pr-ci @sumit-bose