Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-8] Improve performance of certmonger renewal scripts #3630

Closed
wants to merge 2 commits into from

Conversation

rcritten
Copy link
Contributor

@rcritten rcritten commented Sep 6, 2019

This PR was opened automatically because PR #3596 was pushed to master and backport to ipa-4-8 is required.

Wait until we know a supported operation is being called
(SUBMIT and POLL) before initializing the API, which can be
an expensive operation.

https://bugzilla.redhat.com/show_bug.cgi?id=1656519
On startup certmonger performs a number of options on the
configured CA (IPA, not to be confused with the real dogtag CA)
and the tracking requests.

Break early for operations that are not supported by ipa-submit.
This will save both a fork and a lock call.

https://bugzilla.redhat.com/show_bug.cgi?id=1656519
@rcritten
Copy link
Contributor Author

rcritten commented Sep 6, 2019

PR was ACKed automatically because this is backport of PR #3596. Wait for CI to finish before pushing. In case of questions or problems contact @rcritten who is author of the original PR.

@rcritten rcritten added ack Pull Request approved, can be merged re-run Trigger a new run of PR-CI labels Sep 6, 2019
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Sep 6, 2019
@rcritten
Copy link
Contributor Author

rcritten commented Sep 6, 2019

ipa-4-8:

  • 5c5f537 Defer initializing the API in dogtag-ipa-ca-renew-agent-submit
  • a6286e6 Skip lock and fork in ipa-server-guard on unsupported ops

@rcritten rcritten added the pushed Pull Request has already been pushed label Sep 6, 2019
@rcritten rcritten closed this Sep 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants