Re-order tasks.restore_pkcs11_modules() to run earlier #3675
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was executed after restore_all_files() so PKCS11_MODULES was already restored so that part was a no-op, but the redhat restore_pkcs11_modules() also calls unlink() on each restored file so basically the file would be restored, unlinked, then since it was already restored, skipped. By moving the call to restore_pkcs11_modules() earlier it can do the expected restoration properly. https://pagure.io/freeipa/issue/8034 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
|
Hi @rcritten
While testing I discovered that ipa-backup/ipa-restore does not backup the file /etc/pkcs11/modules/softhsm2.module. Issue tracked as 8073, which can be handled in a different fix. |
|
master:
|
This was referenced Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was executed after restore_all_files() so PKCS11_MODULES was
already restored so that part was a no-op, but the redhat
restore_pkcs11_modules() also calls unlink() on each restored
file so basically the file would be restored, unlinked, then
since it was already restored, skipped.
By moving the call to restore_pkcs11_modules() earlier it can
do the expected restoration properly.
https://pagure.io/freeipa/issue/8034
Signed-off-by: Rob Crittenden rcritten@redhat.com