Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipatests: Added testcase to check that ipa-adtrust-install command runs successfully with locale LANG=en_IN.UTF-8 #3738

Closed
wants to merge 1 commit into from
Closed

ipatests: Added testcase to check that ipa-adtrust-install command runs successfully with locale LANG=en_IN.UTF-8 #3738

wants to merge 1 commit into from

Conversation

menonsudhir
Copy link
Contributor

ipatests: Added testcase to check that ipa-adtrust-install command runs successfully with locale set as LANG=en_IN.UTF-8

Issue: https://pagure.io/freeipa/issue/8066

@menonsudhir menonsudhir force-pushed the bz1750242 branch 6 times, most recently from d3c6a1f to d619e17 Compare September 26, 2019 07:55
@menonsudhir menonsudhir added the re-run Trigger a new run of PR-CI label Sep 26, 2019
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Sep 26, 2019
@menonsudhir menonsudhir force-pushed the bz1750242 branch 9 times, most recently from 8270c45 to 9ada13c Compare September 30, 2019 17:24
@menonsudhir menonsudhir added the needs review Pull Request is waiting for a review label Oct 1, 2019
flo-renaud
flo-renaud reviewed Oct 1, 2019
View reviewed changes
Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @menonsudhir
please find inline comments.

ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
@abbra abbra added the WIP Work in progress - not ready yet for review label Oct 10, 2019
@freeipa-pr-ci freeipa-pr-ci added the needs rebase Pull Request cannot be automatically merged - needs to be rebased label Nov 1, 2019
@menonsudhir menonsudhir removed the needs review Pull Request is waiting for a review label Nov 14, 2019
@menonsudhir menonsudhir force-pushed the bz1750242 branch 4 times, most recently from 3596db5 to 50100e4 Compare April 24, 2020 12:45
@menonsudhir menonsudhir added needs review Pull Request is waiting for a review and removed WIP Work in progress - not ready yet for review labels Apr 24, 2020
@menonsudhir menonsudhir force-pushed the bz1750242 branch 2 times, most recently from 9a055e0 to 99d44f4 Compare May 11, 2020 07:19
flo-renaud
flo-renaud reviewed May 11, 2020
View reviewed changes
Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @menonsudhir
please find one inline comment. Otherwise LGTM.

ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
@flo-renaud flo-renaud removed needs rebase Pull Request cannot be automatically merged - needs to be rebased needs review Pull Request is waiting for a review labels May 11, 2020
@menonsudhir menonsudhir force-pushed the bz1750242 branch 4 times, most recently from 3302587 to 8f2191e Compare May 12, 2020 12:17
flo-renaud
flo-renaud reviewed May 12, 2020
View reviewed changes
Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @menonsudhir
please find inline comments.

ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_commands.py Outdated Show resolved Hide resolved
@flo-renaud
Copy link
Contributor

Hi @menonsudhir
thanks for the update, the code LGTM. Let's wait for PR-CI to complete.

@menonsudhir
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@menonsudhir
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@flo-renaud
Copy link
Contributor

Tests are green as can be seen in logs, ACK.

@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label May 13, 2020
@flo-renaud
Copy link
Contributor

@menonsudhir
there is no milestone set on the pagure ticket and no labels for this PR, which branches should it go to? is ipa-4-8 enough?

@menonsudhir menonsudhir added the ipa-4-8 Mark for backport to ipa 4.8 label May 14, 2020
@menonsudhir
Copy link
Contributor Author

@menonsudhir
there is no milestone set on the pagure ticket and no labels for this PR, which branches should it go to? is ipa-4-8 enough?

@flo-renaud i have added ipa-4-8 for now.

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label May 14, 2020
@flo-renaud
Copy link
Contributor

master:

  • 555f8a0 ipatests: Added testcase to check that ipa-adtrust-install command runs successfully with locale set as LANG=en_IN.UTF-8

@flo-renaud flo-renaud closed this May 14, 2020
@flo-renaud flo-renaud mentioned this pull request May 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcritten rcritten rcritten left review comments

@flo-renaud flo-renaud flo-renaud left review comments

@mrizwan93 mrizwan93 mrizwan93 requested changes

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
6 participants
@menonsudhir @flo-renaud @rcritten @mrizwan93 @abbra @freeipa-pr-ci