[Backport][ipa-4-8] ipa user_add: do not check group if UPG is disabled #3743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The UPG plugin is used to create a user private group when a new IPA user is created, with the same name as the user. When this plugin is enabled, the user creation must ensure that no group exists with the same name. When the UPG plugin is disabled, or when the user is created with the --noprivate option, there is no need to perform this check as the private group will not get created. Currently, the --noprivate option correctly skips the test, but a disabled UPG plugin does not skip the test. The fix ensures that UPG plugin status is checked. Fixes: https://pagure.io/freeipa/issue/4972
Add a new XMLRPC test in test_user_plugin: - disable the UPG plugin - create a user without the --gid parameter as the default group for new users is not POSIX (ipausers), the command is expected to fail - create a user with the --gid parameter The provided gid is used and command is expected to succeed - create a user with the same name as an existing group As the UPG plugin is disabled, the user creation will not trigger the creation of a group with the same name, and command is expected to succeed - re-enable the UPG plugin for other tests Related to: https://pagure.io/freeipa/issue/4972
|
PR was ACKed automatically because this is backport of PR #3739. Wait for CI to finish before pushing. In case of questions or problems contact @flo-renaud who is author of the original PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically because PR #3739 was pushed to master and backport to ipa-4-8 is required.