ipatests: in DNS zone file add A record for name server #3837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function create_temp_file was returning unprocessed output of mktemp command, which contains a trailing newline. Callers which tryed to write to the temp file were creating a new one instead.
Testcase test_server_option_with_unreachable_ad creates a zone file for AD domain. This file had a hard-coded A record for host specified in NS record. Some versions of BIND consider this zone invalid and refuse to start with message: ``` zone ad.test/IN: NS 'root-dc.ad.test' has no address records (A or AAAA) ``` Fixed by replacing hard-coded value with short name of the AD instance.
wladich
added
ipa-4-7
ipa-4-6
wladich
force-pushed
the
mktemp-strip-newline
branch
from
4d7045b
to
5c9d870
Compare
|
@miskopo Please review |
|
ACK, please remove the temp commit. |
miskopo
added
ack
wladich
force-pushed
the
mktemp-strip-newline
branch
from
5c9d870
to
b30e1f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testcase test_server_option_with_unreachable_ad creates a zone file
for AD domain. This file had a hard-coded A record for host specified in
NS record. Some versions of BIND consider this zone invalid and refuse
to start with message:
Fixed by replacing hard-coded value with short name of the AD instance.
This PR also fixed utility function create_temp_file which was returning name of created temp file with a trailing newline character added.