[Backport][ipa-4-8] Fix errors found by Pylint-2.4.3 #3853
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New Pylint (2.4.3) catches several new 'true problems'. At the same time, it warns about things that are massively and reasonably employed in FreeIPA. list of fixed: - no-else-continue - redeclared-assigned-name - no-else-break - unnecessary-comprehension - using-constant-test (false positive) list of ignored (responsibility of contributors and reviewers): - import-outside-toplevel Fixes: https://pagure.io/freeipa/issue/8102 Signed-off-by: Stanislav Levin <slev@altlinux.org> Reviewed-By: Fraser Tweedale <ftweedal@redhat.com>
|
This is a duplicate of #3852 |
|
Closing, 3852 was merged. |
|
@rcritten |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #3815 to ipa-4-8 branch. PR was ACKed automatically. Wait for CI to finish before pushing. In case of questions or problems contact @stanislavlevin who is author of the original PR.