Use default ssh host key algorithms #3887
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
needs review
abbra
reviewed
Nov 12, 2019
ipa-client-install no longer overrides SSH client settings for HostKeyAlgorithms. It's no longer necessary to configure HostKeyAlgorithms. The setting was disabling modern algorithms and enabled a weak algorithm that is blocked in FIPS code. The ipa-client package removes IPA's custom HostKeyAlgorithm from /etc/ssh/ssh_config during package update. Non-IPA settings are not touched. Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1756432 Fixes: https://pagure.io/freeipa/issue/8082 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
issue8082_ssh_hostkeyalgo
branch
from
862e7b3
to
52d6753
Compare
|
LGTM |
abbra
added
ack
|
master:
|
This was referenced Nov 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipa-client-install no longer overrides SSH client settings for
HostKeyAlgorithms. It's no longer necessary to configure
HostKeyAlgorithms. The setting was disabling modern algorithms and
enabled a weak algorithm that is blocked in FIPS code.
The ipa-client package removes IPA's custom HostKeyAlgorithm from
/etc/ssh/ssh_config during package update. Non-IPA settings are not
touched.
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1756432
Fixes: https://pagure.io/freeipa/issue/8082
Signed-off-by: Christian Heimes cheimes@redhat.com