Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-8] Covscan fixes #3958

Closed
wants to merge 2 commits into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Nov 29, 2019

This PR was opened automatically because PR #3956 was pushed to master and backport to ipa-4-8 is required.

Even when a number of translated encryption types is zero, the array
might still be allocated. Call free() in any case as free(NULL) does
nothing.

Fixes: https://pagure.io/freeipa/issue/8131
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
On successful code path we leak internal copy of the ucs2-encoded
password.

Fixes: https://pagure.io/freeipa/issue/8131
Signed-off-by: Alexander Bokovoy <abokovoy@redhat.com>
@tiran tiran added the ack Pull Request approved, can be merged label Nov 29, 2019
@tiran
Copy link
Member Author

tiran commented Nov 29, 2019

PR was ACKed automatically because this is backport of PR #3956. Wait for CI to finish before pushing. In case of questions or problems contact @abbra who is author of the original PR.

@tiran tiran added the pushed Pull Request has already been pushed label Nov 29, 2019
@tiran
Copy link
Member Author

tiran commented Nov 29, 2019

ipa-4-8:

  • 84592e3 covscan: free encryption types in case there is an error
  • eebabb5 covscan: free ucs2-encoded password copy when generating NTLM hash

@tiran tiran closed this Nov 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
2 participants