ipatests: make assert_error function compatible with python version < 3.7 #4146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… 3.7 In 3d779b4 assert_error was changed to handle both strings and compiled regexp objects in argument `pattern`. For this it used expression `isinstance(pattern, re.Pattern)`. re.Pattern object was introduced in python 3.7, so the tests which call this function can not be executed with older versions of python though and for now we claim support for python 3.6+. Fixed by replacing the condition with duck-typing check. Fixes: https://pagure.io/freeipa/issue/8179
wladich
force-pushed
the
fix-assert-error
branch
from
571f822
to
0596f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 3d779b4 assert_error was changed to handle both strings and compiled
regexp objects in argument
pattern. For this it used expressionisinstance(pattern, re.Pattern). re.Pattern object was introduced inpython 3.7, so the tests which call this function can not be executed
with older versions of python though and for now we claim support for
python 3.6+.
Fixed by replacing the condition with duck-typing check.
Fixes: https://pagure.io/freeipa/issue/8179