Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport][ipa-4-8] Make assert_error compatible with Python 3.6 #4152

Closed
wants to merge 1 commit into from
Closed

[Backport][ipa-4-8] Make assert_error compatible with Python 3.6 #4152

wants to merge 1 commit into from

Conversation

rcritten
Copy link
Contributor

This PR was opened automatically because PR #4144 was pushed to master and backport to ipa-4-8 is required.

@tiran @rcritten
Make assert_error compatible with Python 3.6
8d7e0f1 
The re.Pattern class was introduced in Python 3.7. Use duck-typing to
distinguish between str and re pattern object.

Fixes: https://pagure.io/freeipa/issue/8179
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@rcritten rcritten added the ack Pull Request approved, can be merged label Jan 22, 2020
@rcritten
Copy link
Contributor Author

PR was ACKed automatically because this is backport of PR #4144. Wait for CI to finish before pushing. In case of questions or problems contact @tiran who is author of the original PR.

@rcritten rcritten added the pushed Pull Request has already been pushed label Jan 23, 2020
@rcritten
Copy link
Contributor Author

ipa-4-8:

  • e9ed8e7 Make assert_error compatible with Python 3.6

@rcritten rcritten closed this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
2 participants
@rcritten @tiran