ipatests: add check for output contents of ipa-client-samba #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wladich
force-pushed
the
check-smb-output
branch
from
2b1f380
to
e8b8a86
Compare
abbra
reviewed
Jan 28, 2020
| domain_regexp_tpl = r''' | ||
| Domain\ name:\s*{domain}\n | ||
| \s*NetBIOS\ name:\s*{netbios}\n | ||
| \s*SID:\s+S-1-5-\d+-\d+-\d+-\d+\n |
There was a problem hiding this comment.
Please check for S-1-5-21-<domain> here. (21 is important). See https://support.microsoft.com/en-us/help/243330/well-known-security-identifiers-in-windows-operating-systemsfor details.
wladich
force-pushed
the
check-smb-output
branch
6 times, most recently
from
8c6a30f
to
84c91f8
Compare
Check that ipa-client-samba tool reports specific properties of domains: name, netbios name, sid and id range Related to https://pagure.io/freeipa/issue/8149
wladich
force-pushed
the
check-smb-output
branch
from
84c91f8
to
54b7f08
Compare
wladich
added
needs review
|
@abbra Please review |
|
LGTM. ACK. |
abbra
added
ack
wladich
force-pushed
the
check-smb-output
branch
from
54b7f08
to
d4156ad
Compare
|
Removed temp commit, waiting for tests |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check that ipa-client-samba tool reports specific properties of domains:
name, netbios name, sid and id range
Related to https://pagure.io/freeipa/issue/8149