Normalize title of test external_ca in prci-definition #4174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssidhaye
reviewed
Jan 29, 2020
|
Hi @Gauravtalreja1 |
Gauravtalreja1
force-pushed
the
change_title_external_ca
branch
from
fba9301
to
300ed05
Compare
Gauravtalreja1
changed the title
Use a consistent way to label the tests. As a result, replace external_ca_1 with test_external_ca_TestExternalCA and external_ca_2 with test_external_ca_TestSelfExternalSelf to better reflect which subtest is executed. Issue : freeipa/freeipa-pr-ci#336 Signed-off-by: Gaurav Talreja <gtalreja@redhat.com>
Gauravtalreja1
force-pushed
the
change_title_external_ca
branch
from
300ed05
to
893e1ab
Compare
|
LGTM. @ssidhaye if you agree with the new comment, you can provide the final ACK |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a consistent way to label the tests. As a result, replace external_ca_1 with test_external_ca_TestExternalCA and external_ca_2 with test_external_ca_TestSelfExternalSelf to better reflect which subtest is executed.
Issue : freeipa/freeipa-pr-ci#336
Signed-off-by: Gaurav Talreja gtalreja@redhat.com