WebUI tests: Fix 'Button is not displayed' exception #4189
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serg-cymbaluk
added
ipa-4-7
WebUI
serg-cymbaluk
force-pushed
the
btn-click
branch
from
4232227
to
d529914
Compare
wladich
reviewed
Feb 3, 2020
ipatests/test_webui/ui_driver.py
Outdated
|
|
||
| # The small timeout (up to 1 second) allows to prevent exceptions when | ||
| # driver attempts to click a button before it is rendered. | ||
| WebDriverWait(self.driver, 1, 0.2).until( |
There was a problem hiding this comment.
I suggest to increase max wait time to 5 seconds - we execute tests in VMs on heavily loaded hosts and I feel that browser can get stuck for second or two.
There was a problem hiding this comment.
Yes, agree, fixed.
serg-cymbaluk
force-pushed
the
btn-click
branch
from
d529914
to
bcd0c48
Compare
wladich
reviewed
Feb 4, 2020
wladich
reviewed
Feb 4, 2020
serg-cymbaluk
force-pushed
the
btn-click
branch
from
bcd0c48
to
bf365d6
Compare
wladich
approved these changes
Feb 4, 2020
|
LGTM. |
serg-cymbaluk
force-pushed
the
btn-click
branch
from
bf365d6
to
314ffc0
Compare
Add a small timeout (up to 5 seconds) which allows to prevent exceptions when WebDriver attempts to click a button before it is rendered. Ticket: https://pagure.io/freeipa/issue/8169 Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
serg-cymbaluk
force-pushed
the
btn-click
branch
from
314ffc0
to
59960aa
Compare
|
ACK |
|
master:
|
This was referenced Feb 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a small timeout (up to 1 second) which allows to prevent exceptions when
WebDriver attempts to click a button before it is rendered.
Ticket: https://pagure.io/freeipa/issue/8169