[Backport][ipa-4-7] ipatests: redesign sssd config editor #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are three patterns for editing sssd.conf in tests now: 1. using modify_sssd_conf() which allows to modify only domain sections 2. using remote_ini_file 3. direct file editing using `sed` This patch introduces new utility function which combines advantages of first two approaches: * changes are verified against schema, so that mistakes can be spotted early * has convenient interface for simple options modification, both in domain and service sections * allows sophisticated modifications through SSSDConfig object Fixes: https://pagure.io/freeipa/issue/8219
Replace usage of remote_ini_file with remote_sssd_config. The latter verifies changes against schema which helps to spot the mistakes. Related to: https://pagure.io/freeipa/issue/8219
`use_fully_qualified_names` is not a valid parameter for `[sssd]` section of sssd.conf, it can be specified only in domain section. According to `man sssd.conf` it simply requires all requests to be fully qualified, otherwise no result will be found. It is irrelevant to the test scenario, so removing it. Related to: https://pagure.io/freeipa/issue/8219
wladich
force-pushed
the
backport-4313-ipa-4-7
branch
from
1dbd57c
to
fe09930
Compare
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a manual backport of #4313