Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipa-4-6] ipatests: remove workaround for pylint error no-name-in-module #4332

Closed
wants to merge 1 commit into from
Closed

[ipa-4-6] ipatests: remove workaround for pylint error no-name-in-module #4332

wants to merge 1 commit into from

Conversation

wladich
Copy link

@wladich wladich commented Mar 10, 2020

As noted by Christian Heimes the proper solution is to add line
from future import absolute_import

Fixes: https://pagure.io/freeipa/issue/8220

@wladich wladich added the re-run Trigger a new run of PR-CI label Mar 11, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Mar 11, 2020
@sorlov-rh
ipatests: remove workaround for pylint error no-name-in-module
2c474da 
The proper solution is to add line
from __future__ import absolute_import

Fixes: https://pagure.io/freeipa/issue/8220
@wladich wladich changed the title ipatests: remove workaround from pylint error no-name-in-module ipatests: remove workaround for pylint error no-name-in-module Mar 11, 2020
@flo-renaud
Copy link
Contributor

Hi @wladich
Thanks for the PR, LGTM. Please remove the temp commit and I will ack when PRCI completes.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged and removed ack Pull Request approved, can be merged labels Mar 11, 2020
@flo-renaud flo-renaud self-assigned this Mar 11, 2020
@flo-renaud flo-renaud changed the title ipatests: remove workaround for pylint error no-name-in-module [ipa-4-6] ipatests: remove workaround for pylint error no-name-in-module Mar 12, 2020
@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Mar 12, 2020
@flo-renaud
Copy link
Contributor

Tests are green, ACK.

@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Mar 12, 2020
@flo-renaud
Copy link
Contributor

ipa-4-6:

  • 46b9139 ipatests: remove workaround for pylint error no-name-in-module

@flo-renaud flo-renaud closed this Mar 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flo-renaud flo-renaud

Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@wladich @flo-renaud @freeipa-pr-ci @sorlov-rh