Allow hosts to read DNS records for IP SAN #4355
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiran
added
prioritized
tiran
force-pushed
the
issue8098-ipsan-aci
branch
from
aa81f32
to
67a8ded
Compare
|
LGTM |
tiran
force-pushed
the
issue8098-ipsan-aci
branch
3 times, most recently
from
f0beae3
to
5dbc04a
Compare
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
tiran
force-pushed
the
issue8098-ipsan-aci
branch
from
5dbc04a
to
fa4e6f8
Compare
|
You add another SAN for the host but it is currently unused. Is that some future change? Should it be removed since it is unused? |
tiran
force-pushed
the
issue8098-ipsan-aci
branch
6 times, most recently
from
5067b14
to
8547f51
Compare
abbra
reviewed
Mar 14, 2020
| # assert dnsnames == {self.clients[0].hostname, self.altname} | ||
| assert dnsnames == {self.clients[0].hostname} | ||
| ipaddrs = set(ext.value.get_values_for_type(x509.IPAddress)) | ||
| assert ipaddrs == {self.clients[0].ip} |
There was a problem hiding this comment.
The assert for ipaddrs fails because you get str in the set on the right side and IPv4Address instance on the lest side:
> assert ipaddrs == {self.clients[0].ip}
E AssertionError: assert {IPv4Address(...168.122.193')} == {'192.168.122.193'}
E Extra items in the left set:
E IPv4Address('192.168.122.193')
E Extra items in the right set:
E '192.168.122.193'
E Full diff:
E - {IPv4Address('192.168.122.193')}
E + {'192.168.122.193'}
I think you either need to convert self.clients[0].ip to an IPAddress instance:
from ipaddress import ip_address
...
assert ipaddrs == {ip_address(self.clients[0].ip)}
8547f51
to
e548475
Compare
|
LGTM |
For SAN IPAddress extension the cert plugin verifies that the IP address matches the host entry. Certmonger uses the host principal to authenticate and retrieve certificates. But the host principal did not have permission to read DNS entries from LDAP. Allow all hosts to read some entries from active DNS records. Fixes: https://pagure.io/freeipa/issue/8098 Signed-off-by: Christian Heimes <cheimes@redhat.com>
tiran
force-pushed
the
issue8098-ipsan-aci
branch
from
e548475
to
c153328
Compare
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For SAN IPAddress extension the cert plugin verifies that the IP address
matches the host entry. Certmonger uses the host principal to
authenticate and retrieve certificates. But the host principal did not
have permission to read DNS entries from LDAP.
Allow all hosts to read some entries from active DNS records.
Fixes: https://pagure.io/freeipa/issue/8098
Signed-off-by: Christian Heimes cheimes@redhat.com