Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ipa-4-6] ipatests: fix covscan issue in test_otp.py #4485

Closed
wants to merge 1 commit into from
Closed

[ipa-4-6] ipatests: fix covscan issue in test_otp.py #4485

wants to merge 1 commit into from

Conversation

flo-renaud
Copy link
Contributor

@flo-renaud flo-renaud added needs review Pull Request is waiting for a review trivial labels Apr 2, 2020
@flo-renaud
Copy link
Contributor Author

@amore17 could you review? Thanks.

@flo-renaud flo-renaud changed the title ipatests: fix covscan issue in test_otp.py [ipa-4-6] ipatests: fix covscan issue in test_otp.py Apr 2, 2020
@netoarmando netoarmando added the prioritized Pull Request has higher priority for PR-CI label Apr 3, 2020
@netoarmando
Copy link
Member

PR-CI fetched the wrong yaml file for serveral pull requests, including this one, it added tasks from gating definitions found in ipa-4-6 branch.

test_otp is defined in temp_commit, it passed, you can remove the temp commit or rebase and force push just to clear the list of tasks.

@flo-renaud
Copy link
Contributor Author

test_otp logs are available here. Removing the temp commit.

@rcritten rcritten added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Apr 3, 2020
@flo-renaud flo-renaud added the pushed Pull Request has already been pushed label Apr 6, 2020
@flo-renaud
Copy link
Contributor Author

ipa-4-6:

  • 8774460 ipatests: fix covscan issue in test_otp.py

@flo-renaud flo-renaud closed this Apr 6, 2020
@flo-renaud flo-renaud deleted the t8255 branch April 6, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@amore17 amore17

Labels
ack Pull Request approved, can be merged prioritized Pull Request has higher priority for PR-CI pushed Pull Request has already been pushed trivial
Projects
None yet
Milestone
No milestone
4 participants
@flo-renaud @netoarmando @rcritten @amore17