Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport][ipa-4-8] ipatests: add test for sssd behavior with disabled trustdomains #4487

Closed
wants to merge 5 commits into from

Conversation

wladich
Copy link

@wladich wladich commented Apr 3, 2020

This is a manual backport of #3924

When a trusted subdomain is disabled in ipa, users from this domain
should not be able to access ipa resources.

Related to: https://pagure.io/SSSD/sssd/issue/4078
The test now requires AD domain + subdomain

Related to: https://pagure.io/SSSD/sssd/issue/4078
This function should be used to conditionally skip tests or
mark them xfail when installed version of sssd does not yet contain
patch for the tested issue.
This function provides functionality similar to pytest.mark.xfail
but for a block of code instead of the whole test function. This has
two benefits:
1) you can mark single line as expectedly failing without suppressing
   all other errors in the test function
2) you can use conditions which can not be evaluated before the test start.

The check is always done in "strict" mode, i.e. if test is expected to
fail but succeeds then it will be marked as failing.
@flo-renaud
Copy link
Contributor

Hi @wladich
thanks for the backport, nightly def LGM and the test is green. Please remove the temp commit and I will ack.

@flo-renaud flo-renaud self-assigned this Apr 3, 2020
@flo-renaud flo-renaud added the ack Pull Request approved, can be merged label Apr 3, 2020
@fcami fcami added the pushed Pull Request has already been pushed label Apr 3, 2020
@fcami
Copy link
Contributor

fcami commented Apr 3, 2020

ipa-4-8:

  • fed6ad2 ipatests: add test for sssd behavior with disabled trustdomains
  • edbb913 update prci definitions for test_sssd.py
  • 3e81b0f ipatests: add utility for getting sssd version on remote host
  • fc253fe ipatests: add context manager for declaring part of test as xfail
  • 8c68b92 ipatests: mark test_trustdomain_disable test as expectedly failing

@fcami fcami closed this Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged pushed Pull Request has already been pushed
Projects
None yet
4 participants