Support for SUSE/openSUSE ipaplatform #4532
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! It's good to finally see SuSE support landing in upstream. The new code uses a slightly different code style than the rest of our code (e.g. single quotes). Could you please run |
tiran
requested changes
Apr 15, 2020
|
The copyright header is with two empty lines before/after. Could you please squash your commits into a single commit to reduce noise? |
Co-authored-by: Howard Guo <hguo@suse.com> Co-authored-by: Daniel Molkentin <dmolkentin@suse.com> Co-authored-by: Marcus Rückert <darix@nordisch.org>
|
LGTM |
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upstreaming much of the work done for FreeIPA 4.6 and updated for 4.8 (well, master)
Building the snapshots of this over on https://build.opensuse.org/package/show/home:hellcp/freeipa, although the build service workers time out while building python parts, so not everything might build there until I tweak the spec (or workers) ;)