Web UI: Upgrade jQuery version 2.0.3 -> 3.4.1 #4565
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serg-cymbaluk
added
ipa-4-6
|
LTGM to me. Did you try it against Chrome/Safari/Edge? |
|
I've tested the patch in Chrome. Let me test it in Edge as well. |
|
Ok, other than the Edge test, things look good to me. |
Ticket: https://pagure.io/freeipa/issue/8284 Signed-off-by: Serhii Tsymbaliuk <stsymbal@redhat.com>
serg-cymbaluk
force-pushed
the
new-jquery
branch
from
b4a00d0
to
ffe6853
Compare
|
The patch has been tested with Edge 44. No visible regressions were found. |
|
ACK |
|
master:
|
This was referenced Apr 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://pagure.io/freeipa/issue/8284