[WIP] pylint: add custom check for forbidden imports #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some modules of FreeIPA should not be importe to some other FreeIPA modules, like ipalib into ipapython
|
Can you turn module matching into a regular expression? We need bit more advanced checks, e.g. |
|
@HonzaCholasta has some WIP patches for this in his drawer which may be better than this, so closing this PR in favor of Honza's patches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some modules of FreeIPA should not be imported to some other FreeIPA
modules, like ipalib into ipapython
This is WIP, it misses a lot of rules and I had hard time with naming variables, feedback more than welcome.