Use DogTag's two step installation for CA only #4796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fcami
added
WIP
fcami
changed the title
rcritten
reviewed
Aug 17, 2020
| ipautil.run(args, nolog=nolog_list) | ||
| else: | ||
| args = list(args) | ||
| ipautil.run(args, nolog=nolog_list) |
There was a problem hiding this comment.
Why make args a tuple only to convert it into a list, especially when it is always converted?
Some configuration items of Dogtag are only available using a 2-step installation method described at: https://www.dogtagpki.org/wiki/Two-Step_Installation Fixes: https://pagure.io/freeipa/issue/8438 Signed-off-by: François Cami <fcami@redhat.com>
Use Dogtag's two-step installation method for CAs to be able to customize some parameters like CA lifetime. Fixes: https://pagure.io/freeipa/issue/8438 Signed-off-by: François Cami <fcami@redhat.com>
POSIX time values, which measure the number of seconds since January 1 1970, will exceed the maximum value representable in a signed 32-bit integer in January 2038. Limit CA lifetime to before the end date. Fixes: https://pagure.io/freeipa/issue/7827 Signed-off-by: François Cami <fcami@redhat.com>
freeipa-pr-ci
added
the
needs rebase
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
This issue has been automatically closed as stale it has not had recent activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some configuration items of Dogtag are only available using a 2-step
installation method described at:
https://www.dogtagpki.org/wiki/Two-Step_Installation
dogtaginstance.py: enable two-step Dogtag instance installation
cainstance.py: use Dogtag's two-step installation method
Use Dogtag's two-step installation method for CAs to be
able to customize some parameters like CA lifetime.
Related: https://pagure.io/freeipa/issue/7827
Fixes: https://pagure.io/freeipa/issue/8438