ipa-replica-install: --setup-ca and *-cert-file are mutually exclusive #4802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rcritten
previously requested changes
Jun 10, 2020
| options.pkinit_cert_files]): | ||
| raise ScriptError("--setup-ca and *-cert-file options are " | ||
| "mutually exclusive") | ||
|
|
There was a problem hiding this comment.
I've move this to the very top of the function. There is no point in doing all the other work without being able to move forward with the installation.
This actually tries to do an installation and fails:
# ipa-replica-install --setup-ca --http-cert-file=/tmp/foo --dirsrv-cert-file=/tmp/foo --no-pkinit
Configuring client side components
This program will set up FreeIPA client.
Version 4.9.0.dev202006101846+git27b2db9dc
One of password / principal / keytab is required.
The ipa-client-install command failed. See /var/log/ipaclient-install.log for more information
Removing client side components
IPA client is not configured on this system.
The ipa-client-install command failed.
Your system may be partly configured.
Run /usr/sbin/ipa-server-install --uninstall to clean up.
Configuration of client side components failed!
The ipa-replica-install command failed. See /var/log/ipareplica-install.log for more information
There was a problem hiding this comment.
Good point, implemented in the new commit.
ipa-replica-install currently accepts both --setup-ca and *-cert-file even though the options should be mutually exclusive (either install CA-less with *-cert-file options or with a CA). Add a check enforcing the options are mutually exclusive. Fixes: https://pagure.io/freeipa/issue/8366
The options *-cert-file are used for a CA-less replica installation and are mutually exclusive with --setup-ca. Add a test for this use case. Related: https://pagure.io/freeipa/issue/8366
|
Changes look good. Please remove the temp commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipa-replica-install: --setup-ca and *-cert-file are mutually exclusive
ipa-replica-install currently accepts both --setup-ca and *-cert-file
even though the options should be mutually exclusive (either install
CA-less with *-cert-file options or with a CA).
Add a check enforcing the options are mutually exclusive.
Fixes: https://pagure.io/freeipa/issue/8366
ipatests: add a test for ipa-replica-install --setup-ca --http-cert-file
The options *-cert-file are used for a CA-less replica installation and
are mutually exclusive with --setup-ca.
Add a test for this use case.
Related: https://pagure.io/freeipa/issue/8366