Ship EPN's configuration file. #4848
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It failed because: I don't see anything obviously wrong with the patch. I'd think that rpm would blow up if it wasn't there. It could be an order-of-execution issue perhaps. |
|
Blocked by freeipa/freeipa-pr-ci#378 |
|
/AzurePipelines run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
fcami
added
needs review
Ship and install /etc/ipa/epn.conf. Minor fixes to the associated man page. Fixes: https://pagure.io/freeipa/issue/8374 Signed-off-by: François Cami <fcami@redhat.com>
Fix formatting issues found with mandoc. Signed-off-by: François Cami <fcami@redhat.com>
Fixes: https://pagure.io/freeipa/issue/8374 Signed-off-by: François Cami <fcami@redhat.com>
abbra
reviewed
Jun 25, 2020
Due to freeipa/freeipa-pr-ci#378 the installed version of freeipa-client-epn is not the built one. Temporarily force uninstall/reinstall of this package before running the test. Fixes: https://pagure.io/freeipa/issue/8374 Signed-off-by: François Cami <fcami@redhat.com>
|
hi @abbra Thanks for the hint & I've added your suggested change. Could you please let me know if you'd like anything else changed? |
|
The rest looks good. Please remove the temp commit. |
|
Thanks @abbra I've removed the temp commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipatests: check that EPN's configuration file is installed.
Fixes: https://pagure.io/freeipa/issue/8374
man pages: fix epn.conf.5 and ipa-epn.1 formatting
Fix formatting issues found with mandoc.
EPN: ship the configuration file.
Ship and install /etc/ipa/epn.conf.
Minor fixes to the associated man page.
Fixes: https://pagure.io/freeipa/issue/8374