Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipatests: Tests to check profile and issue field is displayed for getcert request #4888

Closed
wants to merge 1 commit into from
Closed

ipatests: Tests to check profile and issue field is displayed for getcert request #4888

wants to merge 1 commit into from

Conversation

menonsudhir
Copy link
Contributor

test_getcert_list_profile
This test checks that the cert request generated using getcert utility which is placed in /var/lib/certmonger/requests
directory displays profile name and issuer fields

test_getcert_list_profile_using_subca
This test checks that the cert request generated with -X as subca and -T displays correct profilename

@menonsudhir menonsudhir force-pushed the cert_test branch 3 times, most recently from 7e4e8e2 to 7cf91e2 Compare July 6, 2020 12:59
mrizwan93
mrizwan93 reviewed Jul 7, 2020
View reviewed changes
ipatests/test_integration/test_cert.py Outdated Show resolved Hide resolved
ipatests/test_integration/test_cert.py Outdated Show resolved Hide resolved
@menonsudhir menonsudhir force-pushed the cert_test branch 4 times, most recently from 41fd119 to c116c43 Compare July 9, 2020 14:30
@menonsudhir
Copy link
Contributor Author

@rcritten i don't see the profile attribute for the certificate request being monitored, the certmonger installed is
certmonger-0.79.9-1.fc32.x86_64.
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 Request ID 'test-request':
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 status: MONITORING
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 stuck: no
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 key pair storage: type=FILE,location='/etc/pki/tls/private/test.key'
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 certificate: type=FILE,location='/etc/pki/tls/certs/test.pem'
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 CA: IPA
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 issuer: CN=SUBCA
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 subject: CN=master.ipa.test,O=IPA.TEST
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 expires: 2022-07-10 14:54:28 UTC
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 dns: master.ipa.test
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 principal name: host/master.ipa.test@IPA.TEST
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 key usage: digitalSignature,nonRepudiation,keyEncipherment,dataEncipherment
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 eku: id-kp-serverAuth,id-kp-clientAuth
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 pre-save command:
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 post-save command:
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 track: yes
DEBUG ipatests.pytest_ipa.integration.host.Host.master.cmd59:transport.py:557 auto-renew: yes

@rcritten rcritten added the re-run Trigger a new run of PR-CI label Jul 9, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 9, 2020
@rcritten
Copy link
Contributor

rcritten commented Jul 9, 2020

The test is failing because it isn't picking up the latest certmonger release. It is still using certmonger-0.79.9-1.fc32.x86_64 which lacks the updated package. I don't know if this is an image problem or not. The package was pushed to stable today so maybe this will clear itself up shortly.

@menonsudhir menonsudhir force-pushed the cert_test branch 9 times, most recently from 6390c7f to 45944eb Compare July 10, 2020 11:31
@menonsudhir
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rcritten rcritten added ipa-4-8 Mark for backport to ipa 4.8 re-run Trigger a new run of PR-CI labels Jul 10, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 10, 2020
@rcritten
Copy link
Contributor

certmonger is included with the template. Once an updated template is available this can be rebased and it should pass. Azure passes because it pulls from updates.

@menonsudhir
Copy link
Contributor Author

menonsudhir commented Jul 13, 2020 •
edited

@rcritten seems that the template isn't updated yet.

@flo-renaud
Copy link
Contributor

@menonsudhir
I just pushed the PR #4911 that updates the template with certmonger-0.79.11-2. You can rebase and it will pick the good template.

@menonsudhir
ipatests: Tests to check profile is displayed for getcert request.
1c29b9c 
test_getcert_list_profile
This test checks that the cert request generated using
getcert utility which is placed in /var/lib/certmonger/requests
directory displays profile name and issuer fields

test_getcert_list_profile_using_subca
This test checks that the cert request generated with -X as
subca and -T <profilename> displays correct profilename
@menonsudhir
Copy link
Contributor Author

@menonsudhir
I just pushed the PR #4911 that updates the template with certmonger-0.79.11-2. You can rebase and it will pick the good template.

@flo-renaud thank you have rebased.

@menonsudhir
Copy link
Contributor Author

/AzurePipelines run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@rcritten
Copy link
Contributor

Looks good, please remove the temporary commit.

@flo-renaud
Copy link
Contributor

Tests are green, ACK.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Jul 15, 2020
@flo-renaud
Copy link
Contributor

master:

  • 8e05a8a ipatests: Tests to check profile is displayed for getcert request.

@flo-renaud flo-renaud closed this Jul 15, 2020
@flo-renaud flo-renaud mentioned this pull request Jul 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rcritten rcritten rcritten left review comments

@mrizwan93 mrizwan93 mrizwan93 left review comments

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
5 participants
@menonsudhir @rcritten @flo-renaud @mrizwan93 @freeipa-pr-ci