Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipa-join: handle JSON-RPC error codes #4910

Closed
wants to merge 2 commits into from
Closed

ipa-join: handle JSON-RPC error codes #4910

wants to merge 2 commits into from

Conversation

Carbenium
Copy link
Contributor

Handling of IPA error codes was missing from the JSON-RPC code paths.
Add parsing support for the error object and handle ACIError explicitly to match XML-RPC behaviour.

Fixes: https://pagure.io/freeipa/issue/8408

@Carbenium
ipa-join: extract common JSON-RPC response parsing to common function
1c736a1 
In preparation for handling JSON-RPC error codes.

Related: https://pagure.io/freeipa/issue/8408
@Carbenium
ipa-join: handle JSON-RPC error codes
d839f68 
Error code 2100 (ACIError) is handled explicitly to match XML-RPC behaviour.

Fixes: https://pagure.io/freeipa/issue/8408
@rcritten rcritten added ipa-next Mark as master (4.12) only re-run Trigger a new run of PR-CI labels Jul 10, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 10, 2020
@rcritten rcritten added the re-run Trigger a new run of PR-CI label Jul 10, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 10, 2020
@rcritten rcritten added the re-run Trigger a new run of PR-CI label Jul 13, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jul 13, 2020
@rcritten
Copy link
Contributor

fedora-latest/test_advise failed due to timeout, fedora-latest/test_replica_promotion_TestSubCAkeyReplication with CA spawn issue. Neither related to join. Curious they both failed twice.

@flo-renaud flo-renaud self-assigned this Jul 15, 2020
@flo-renaud
Copy link
Contributor

Hi @Carbenium
thanks for the fix, works for me. I manually ran test_integration/test_replica_promotion.py::TestUnprivilegedUserPermissions and it succeeded, also tested manually:

  • ipa-client-install with non-admin user produces the error msg Joining realm failed: No permission to join this host to the IPA domain.
  • promotion using ipa-replica-install with non-admin user produces the error msg Insufficient privileges to promote the server.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Jul 15, 2020
@flo-renaud
Copy link
Contributor

master:

  • 4696644 ipa-join: extract common JSON-RPC response parsing to common function
  • 6dfefc9 ipa-join: handle JSON-RPC error codes

@flo-renaud flo-renaud closed this Jul 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@flo-renaud flo-renaud

Labels
ack Pull Request approved, can be merged ipa-next Mark as master (4.12) only pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
4 participants
@Carbenium @rcritten @flo-renaud @freeipa-pr-ci