ipatests: fix test_replica_promotion.py #4926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adding ipa-4-8 label as the failing tests were also backported to this branch with PR #4917 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
mrizwan93
approved these changes
Jul 17, 2020
|
LGTM |
|
LGTM as well. Please remove the temp commit. |
|
Apologies for inadvertently introducing these testing bugs in my PR, and a big thank you to @flo-renaud for fixing it. |
|
@jsf9k it's more my fault for not catching it in the first place. @flo-renaud reminder to remove the temp commit. |
A new test has been added to TestUnprivilegedUserPermissions that duplicates the steps done in the precedent test. As the tests are usually run sequentially, no need to duplicate. Fixes: https://pagure.io/freeipa/issue/8413
A new test was added to TestReplicaPromotionLevel1 but was run after the replica uninstallation. As the new test checks the content of /etc/sssd/sssd.conf on the replica, merge it with the previous test, when the replica is still installed. Fixes: https://pagure.io/freeipa/issue/8414
|
Rebased to master and removed the temp commit. |
mrizwan93
added
ack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipatests: Fix TestReplicaPromotionLevel1
A new test was added to TestReplicaPromotionLevel1 but was run
after the replica uninstallation. As the new test checks
the content of /etc/sssd/sssd.conf on the replica, merge it with the
previous test, when the replica is still installed.
Fixes: https://pagure.io/freeipa/issue/8414
ipatests: fix TestUnprivilegedUserPermissions
A new test has been added to TestUnprivilegedUserPermissions that
duplicates the steps done in the precedent test. As the tests
are usually run sequentially, no need to duplicate.
Fixes: https://pagure.io/freeipa/issue/8413