Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ipatests: Test healthcheck revocation checker #4990

Closed
wants to merge 1 commit into from
Closed

ipatests: Test healthcheck revocation checker #4990

wants to merge 1 commit into from

Conversation

rcritten
Copy link
Contributor

@rcritten rcritten commented Aug 5, 2020

Revoke the Apache certificate and ensure that healthcheck properly
reports the problem.

@rcritten
ipatests: Test healthcheck revocation checker
9572c52 
Revoke the Apache certificate and ensure that healthcheck properly
reports the problem.
@rcritten rcritten added needs review Pull Request is waiting for a review ipa-4-8 Mark for backport to ipa 4.8 labels Aug 5, 2020
mrizwan93
mrizwan93 approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@mrizwan93 mrizwan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
temp commit results: http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/08c00fa6-d6b4-11ea-b3e5-fa163e401a00/

@mrizwan93 mrizwan93 added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Aug 5, 2020
@abbra abbra removed the ack Pull Request approved, can be merged label Aug 5, 2020
@abbra
Copy link
Contributor

abbra commented Aug 5, 2020

Please remove temp commit. @mrizwan93 we typically do not add ACK before all PR CI tests passed.

@mrizwan93
Copy link
Contributor

@abbra Ahh, sorry for that.

@rcritten
Copy link
Contributor Author

rcritten commented Aug 5, 2020

Temp patch removed.

@rcritten
Copy link
Contributor Author

rcritten commented Aug 5, 2020

Since the board is green again after removing the temp commit I'll add back the ack.

@rcritten rcritten added the ack Pull Request approved, can be merged label Aug 5, 2020
@rcritten
Copy link
Contributor Author

rcritten commented Aug 5, 2020

master:

  • 61db352 ipatests: Test healthcheck revocation checker

@rcritten rcritten added the pushed Pull Request has already been pushed label Aug 5, 2020
@rcritten rcritten closed this Aug 5, 2020
@rcritten rcritten mentioned this pull request Aug 5, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrizwan93 mrizwan93 mrizwan93 approved these changes

Assignees
No one assigned
Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
Milestone
No milestone
3 participants
@rcritten @abbra @mrizwan93