Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase timeout for test_cert.py #5053

Closed
wants to merge 1 commit into from

Conversation

ssidhaye
Copy link
Contributor

@ssidhaye ssidhaye commented Aug 21, 2020

test_cert.py is timing out due to newly added test

test_cert.py::TestCertmongerRekey which needs more time to execute.
Adding additional 30 mins to the timeout in order to complete the test run

Failing test run:
http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/249e30e4-e349-11ea-ac03-fa163e1ffcbd

Signed-off-by: Sumedh Sidhaye ssidhaye@redhat.com

@flo-renaud
Copy link
Contributor

flo-renaud commented Aug 21, 2020

Hi @ssidhaye
Thanks for the PR. Could you add a temp commit to check that the additional 30min are enough? Thanks.
Also, the test is defined in multiple nightly files, don't forget to update all of them.

@flo-renaud flo-renaud self-assigned this Aug 21, 2020
@ssidhaye
Copy link
Contributor Author

Increased timeout in other nightly yamls.

@flo-renaud
Copy link
Contributor

Hi @ssidhaye
it looks like the new timeout is sufficient (temp commit succeeded, link to report).

I didn't notice at first but the test is also launched in gating.yaml. You can remove the temp commit and increase the timeout in gating.yaml (the azure failure is unrelated).

test_cert.py::TestCertmongerRekey which needs more time to execute.
Adding additional 30 mins to the timeout in order to complete the test run

Failing test run:
http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/249e30e4-e349-11ea-ac03-fa163e1ffcbd

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
@ssidhaye
Copy link
Contributor Author

Increased timeout in gating.yaml as well. Removed temp commit

@ssidhaye ssidhaye added the ipa-4-8 Mark for backport to ipa 4.8 label Aug 24, 2020
@flo-renaud
Copy link
Contributor

Hi @ssidhaye
thanks for the fix, LGTM. Tests are green and all the required nightly definitions have been updated with the new timeout.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged pushed Pull Request has already been pushed labels Aug 24, 2020
@flo-renaud
Copy link
Contributor

master:

  • 3f5f68e test_cert.py is timing out due to newly added test test_cert.py::TestCertmongerRekey which needs more time to execute. Adding additional 30 mins to the timeout in order to complete the test run

@flo-renaud flo-renaud closed this Aug 24, 2020
@flo-renaud
Copy link
Contributor

@ssidhaye a manual backport is required for ipa-4-8, can you handle it? thanks

@ssidhaye
Copy link
Contributor Author

@flo-renaud Sure, I can do that.

ssidhaye added a commit to ssidhaye/freeipa that referenced this pull request Aug 24, 2020
freeipa#5053

Increase test_cert.py timeout from 3600 to 5400
to accomodate newly added tests that need more time
to execute

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
@ssidhaye
Copy link
Contributor Author

Manual backport for ipa-4-8 : #5061

freeipa-pr-ci2 pushed a commit to freeipa-pr-ci2/freeipa that referenced this pull request Aug 24, 2020
Increase test_cert.py timeout from 3600 to 5400
to accomodate newly added tests that need more time
to execute

Signed-off-by: Sumedh Sidhaye <ssidhaye@redhat.com>
Reviewed-By: Alexander Bokovoy <abbra@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
2 participants