[Backport][ipa-4-8] ipatests: refactor new tests in test_smb #5065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test had two problems: * if it was failing, samba services were not started and all other tests also failed * Utility for copying keys obscured fatal problems i.e. if file does not exist or can not be parsed. Fixed by moving the check to separate test and raising exceptions in KerberosKeyCopier on any unexpected problem.
Fixture enable_smb_client_dns_lookup_kdc had an unobvious structure "contextmanage inside pytest fixture". Replaced with simple pytest fixture.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically because PR #4994 was pushed to master and backport to ipa-4-8 is required.