Set the certmonger subject with a string, not an object #5084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ipa-server-certinstall takes a slightly different code path if the replacement certificate is IPA-issued so exercise that path. This replaces the Apache cert with itself which is a bit of a no-op but it still goes through the motions. https://pagure.io/freeipa/issue/8204 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
ipa-server-certinstall goes through a slightly different code path if the replacement certificate is issued by IPA. This was setting the subject using cert.subject which is a Name object and not the string representation of that object. This was failing in the dbus call to certmonger. https://pagure.io/freeipa/issue/8204 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
frasertweedale
added
ack
|
ACK from me, when temp commit removed and CI green. PRCI temp_commit job (succeeded): http://freeipa-org-pr-ci.s3-website.eu-central-1.amazonaws.com/jobs/f6503fc0-f225-11ea-8d4d-fa163e19313f |
|
Thanks. Temp commit removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipa-server-certinstall goes through a slightly different code path
if the replacement certificate is issued by IPA. This was setting
the subject using cert.subject which is a Name object and not the
string representation of that object. This was failing in the
dbus call to certmonger.
https://pagure.io/freeipa/issue/8204
Signed-off-by: Rob Crittenden rcritten@redhat.com