Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure_dns_resolver: call self.restore_context #5162

Closed
wants to merge 1 commit into from

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 29, 2020

Use the platform implementation of restore_context() instead of the base
implementation.

Fixes: https://pagure.io/freeipa/issue/8518
Signed-off-by: Christian Heimes cheimes@redhat.com

Use the platform implementation of restore_context() instead of the base
implementation.

Fixes: https://pagure.io/freeipa/issue/8518
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@tiran tiran added needs review Pull Request is waiting for a review container FreeIPA in container effort ipa-4-8 Mark for backport to ipa 4.8 labels Sep 29, 2020
@abbra
Copy link
Contributor

abbra commented Sep 29, 2020

I tested this change manually and it solved the problem for me.

@abbra abbra removed the needs review Pull Request is waiting for a review label Sep 29, 2020
@tiran tiran added the re-run Trigger a new run of PR-CI label Sep 29, 2020
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Sep 29, 2020
@tiran tiran added the re-run Trigger a new run of PR-CI label Sep 29, 2020
@tiran
Copy link
Member Author

tiran commented Sep 29, 2020

fedora-latest/test_cert has timed out for the second time

@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Sep 29, 2020
@abbra
Copy link
Contributor

abbra commented Sep 30, 2020

Fedora OpenQA tests succeeded with systemd-resolved upgrade. ACK.

@abbra abbra added the ack Pull Request approved, can be merged label Sep 30, 2020
@tiran tiran added the pushed Pull Request has already been pushed label Sep 30, 2020
@tiran
Copy link
Member Author

tiran commented Sep 30, 2020

master:

  • 38d083e configure_dns_resolver: call self.restore_context

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged container FreeIPA in container effort ipa-4-8 Mark for backport to ipa 4.8 pushed Pull Request has already been pushed
Projects
None yet
3 participants