Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry chronyc waitsync only once #5166

Closed
wants to merge 1 commit into from
Closed

Conversation

tiran
Copy link
Member

@tiran tiran commented Sep 29, 2020

It's unlikely that a third chrony synchronization attempt is going to
succeed after the the first two attempts have failed. Perform more
retries with smaller timeout.

This speed up installer by 11 seconds on systems without fully
configured chronyd or no chronyd (e.g. containers).

Related: https://pagure.io/freeipa/issue/8521
Signed-off-by: Christian Heimes cheimes@redhat.com

@tiran tiran added needs review Pull Request is waiting for a review ipa-next Mark as master (4.12) only labels Sep 29, 2020
@tiran tiran requested a review from Tiboris September 29, 2020 11:41
ipaclient/install/timeconf.py Outdated Show resolved Hide resolved
It's unlikely that a third chrony synchronization attempt is going to
succeed after the the first two attempts have failed. Perform more
retries with smaller timeout.

This speed up installer by 11 seconds on systems without fully
configured chronyd or no chronyd (e.g. containers).

Related: https://pagure.io/freeipa/issue/8521
Signed-off-by: Christian Heimes <cheimes@redhat.com>
@fcami
Copy link
Contributor

fcami commented Sep 29, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@fcami
Copy link
Contributor

fcami commented Sep 29, 2020

LGTM.

@fcami fcami added ack Pull Request approved, can be merged and removed needs review Pull Request is waiting for a review labels Sep 30, 2020
@tiran tiran added the pushed Pull Request has already been pushed label Sep 30, 2020
@tiran
Copy link
Member Author

tiran commented Sep 30, 2020

master:

  • 3ab3ed5 Retry chronyc waitsync only once

@tiran tiran closed this Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-next Mark as master (4.12) only pushed Pull Request has already been pushed
Projects
None yet
2 participants