[Backport][ipa-4-8] Use a state to determine if a 389-ds upgrade is in progress #5211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When applying update files to 389 the listeners are disabled. There is a large try/except around this so that if a failure happens then the configuration should be automatically restored. We've seen multiple cases where this doesn't occur. Best guess is that users are killing or ^C breaking out of the script. What happens in that case is that when the next upgrade is run the configuration is backed up again overwriting the original values. This leaves dirsrv with no listener on 389. Add a new state, upgrade-in-progress, so that the backup of the config information can be skipped when the upgrader is executed again after a failure. The idea behind using a new state value is that if additional attributes are ever backed up we don't need to remember to update the list of possible saved values to check to decide if the upgrade is in progress. https://pagure.io/freeipa/issue/7534 Signed-off-by: Rob Crittenden <rcritten@redhat.com>
rcritten
added
ack
|
ipa-4-8:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically because PR #5207 was pushed to master and backport to ipa-4-8 is required.