installer: update time estimates #529
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This will say during replica installation (DL1): but the operation lasts ~5 seconds at most. |
nicki-krizek
force-pushed
the
t6596-update-eta-in-installers
branch
from
1ec69e6
to
3ee3251
Compare
nicki-krizek
commented
Mar 7, 2017
ipaserver/install/krainstance.py
Outdated
| @@ -134,8 +134,13 @@ def configure_instance(self, realm_name, host_name, dm_password, | |||
|
|
|||
| self.step("enabling KRA instance", self.__enable_instance) | |||
|
|
|||
| if ra_only: | |||
There was a problem hiding this comment.
Not sure if this is necessary. Is kra install ever executed with ra_only=True option?
There was a problem hiding this comment.
Please rebase on current master
edit: never mind, you are rebased. I have no idea why you added this.
|
@stlaz That estimate was a bit off :) Thanks for noticing! |
nicki-krizek
force-pushed
the
t6596-update-eta-in-installers
branch
from
3ee3251
to
d2ba0a1
Compare
stlaz
reviewed
Mar 10, 2017
ipaserver/install/service.py
Outdated
| @@ -401,7 +401,7 @@ def start_creation(self, start_message=None, end_message=None, | |||
| else: | |||
| end_message = "Done configuring %s." % self.service_desc | |||
|
|
|||
| if runtime > 0: | |||
| if runtime and runtime > 0: | |||
There was a problem hiding this comment.
The correct condition is if runtime is not None and and runtime > 0
There was a problem hiding this comment.
SyntaxError: invalid syntax :-P
|
Please fix the little issue and we will push this. |
Time estimates have been updated to be more accurate. Only tasks that are estimated to take longer than 10 seconds have the estimate displayed. https://pagure.io/freeipa/issue/6596
nicki-krizek
force-pushed
the
t6596-update-eta-in-installers
branch
from
d2ba0a1
to
adfafc3
Compare
|
master:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Time estimates have been updated to be more accurate. Only
tasks that are estimated to take longer than 10 seconds have
the estimate displayed.
https://pagure.io/freeipa/issue/6596