[Backport][ipa-4-8] Fix scope on pytest fixture in krbtpolicy tests #5296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0d67180 introduced the with_admin fixture using class scope, which caused test failures as pytest instantiated it before the multihost fixture. It additionally failed to account for jitter - the issued ticket becomes within a window of the expected lifetime, so we need to include the ticket lifetime jitter into that calculation. Finally, the PKINIT test could not have ever worked because PKINIT is not set up as part of policy testing. Related: https://pagure.io/freeipa/issue/8590 Also-authored-by: Rob Crittenden <rcritten@redhat.com> Signed-off-by: Robbie Harwood <rharwood@redhat.com> Signed-off-by: Rob Crittenden <rcritten@redhat.com>
|
PR was ACKed automatically because this is backport of PR #5281. Wait for CI to finish before pushing. In case of questions or problems contact @frozencemetery who is author of the original PR. |
rcritten
added
ack
|
ipa-4-8:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was opened automatically because PR #5281 was pushed to master and backport to ipa-4-8 is required.