Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipatests: do not set dns_lookup to true #5398

Closed
wants to merge 1 commit into from

Conversation

wladich
Copy link

@wladich wladich commented Jan 6, 2021

dns_lookup was set to false during ipa client installation which prevented
searches for SRV records for Kerberos servers.
Since https://pagure.io/freeipa/issue/6523 is fixed, dns_lookup is always True
now and the fixture is not needed anymore.

dns_lookup was set to false during ipa client installation which prevented
searches for SRV records for Kerberos servers.
Since https://pagure.io/freeipa/issue/6523 is fixed, dns_lookup is always True
now and the fixture is not needed anymore.
@wladich wladich force-pushed the remove-workaround-dns-lookup branch from 4bb44ca to 436d965 Compare January 6, 2021 13:37
@wladich wladich added ipa-4-8 Mark for backport to ipa 4.8 ipa-4-9 Mark for backport to ipa 4.9 labels Jan 6, 2021
Copy link
Contributor

@fcami fcami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wladich
Copy link
Author

wladich commented Jan 6, 2021

@wladich wladich force-pushed the remove-workaround-dns-lookup branch from 436d965 to 69c34ae Compare January 6, 2021 14:33
@wladich wladich added the re-run Trigger a new run of PR-CI label Jan 6, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jan 6, 2021
Copy link
Contributor

@fcami fcami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK from me

@fcami fcami added the ack Pull Request approved, can be merged label Jan 7, 2021
@wladich
Copy link
Author

wladich commented Jan 7, 2021

master:

  • b707af1 ipatests: do not set dns_lookup to true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-4-8 Mark for backport to ipa 4.8 ipa-4-9 Mark for backport to ipa 4.9 pushed Pull Request has already been pushed
Projects
None yet
4 participants