ipatest: fix test_upgrade.py::TestUpgrade::()::test_kra_detection #5424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modify the test scenario in order to be independant from PKI behavior. The aim of the test is to ensure that the KRA detection is not based on the presence of the directory /var/lib/pki/pki-tomcat/kra/. Previously the test was calling ipa-server-upgrade but this cmd may fail even with the kra detection fix because of an issue in pki (dogtagpki/pki#3397). Instead of exercising the whole ipa-server-upgrade command, the test now checks the output of the API kra.is_installed() to validate KRA detection mechanism. Fixes: https://pagure.io/freeipa/issue/8653 Related: https://pagure.io/freeipa/issue/8596 Signed-off-by: Florence Blanc-Renaud <flo@redhat.com>
flo-renaud
added
ipa-4-6
fcami
added
ack
|
master:
|
This was referenced Jan 14, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify the test scenario in order to be independant from PKI
behavior. The aim of the test is to ensure that the KRA
detection is not based on the presence of the directory
/var/lib/pki/pki-tomcat/kra/.
Previously the test was calling ipa-server-upgrade but this cmd
may fail even with the kra detection fix because of an issue in
pki (dogtagpki/pki#3397).
Instead of exercising the whole ipa-server-upgrade command, the
test now checks the output of the API kra.is_installed() to validate
KRA detection mechanism.
Fixes: https://pagure.io/freeipa/issue/8653
Related: https://pagure.io/freeipa/issue/8596
Signed-off-by: Florence Blanc-Renaud flo@redhat.com