Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipatests: Test if server setup without dns uninstall properly #5443

Closed
wants to merge 2 commits into from

Conversation

mrizwan93
Copy link
Contributor

IPA server uninstall was failing if dns was not setup.
This test check if it uninstalls propelry.

related: https://pagure.io/freeipa/issue/8630
Signed-off-by: Mohammad Rizwan myusuf@redhat.com

@kaleemsiddiqu
Copy link
Contributor

@mrizwan93
How about a separate test file for uninstall tests?

@mrizwan93 mrizwan93 force-pushed the bz1909876 branch 2 times, most recently from ba1c172 to 245e418 Compare January 19, 2021 11:24
@mrizwan93 mrizwan93 added the re-run Trigger a new run of PR-CI label Jan 19, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jan 19, 2021
@mrizwan93 mrizwan93 force-pushed the bz1909876 branch 2 times, most recently from ddfb3cf to 48838c4 Compare January 19, 2021 13:19
@@ -68,7 +68,7 @@ jobs:
class: RunPytest
args:
build_url: '{fedora-latest/build_url}'
test_suite: test_integration/test_REPLACEME.py
test_suite: test_integration/test_uninstall.py::UninstallWithoutDNS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in the temp commit, should be:

         test_suite: test_integration/test_uninstall.py::TestUninstallWithoutDNS 

@mrizwan93 mrizwan93 added the needs review Pull Request is waiting for a review label Jan 20, 2021
@kaleemsiddiqu
Copy link
Contributor

LGTM, temp commit can be removed.

@mrizwan93
Copy link
Contributor Author

Thanks @kaleemsiddiqu
Temp commit removed.

temp commit results

Copy link
Contributor

@flo-renaud flo-renaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrizwan93
as there is a new test file, you need to add job definitions in ipatests/prci_definitions/*.yaml. No need to add the new test in gating.yaml, nightly_latest_pki.yaml or nightly_latest_389ds.yaml but the test needs to be defined in the other files.

IPA server uninstall was failing if dns was not setup.
This test check if it uninstalls propelry.

related: https://pagure.io/freeipa/issue/8630
Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
@mrizwan93 mrizwan93 added ipa-4-9 Mark for backport to ipa 4.9 re-run Trigger a new run of PR-CI labels Jan 20, 2021
@freeipa-pr-ci freeipa-pr-ci removed the re-run Trigger a new run of PR-CI label Jan 20, 2021
@flo-renaud
Copy link
Contributor

@mrizwan93 thanks for the update, the nightly definitions LGTM.

@flo-renaud flo-renaud added ack Pull Request approved, can be merged pushed Pull Request has already been pushed and removed needs review Pull Request is waiting for a review labels Jan 20, 2021
@flo-renaud
Copy link
Contributor

master:

  • 69d4800 ipatests: Test if server setup without dns uninstall properly
  • 74b4d7e ipatests: Add test_uninstall.py to nightly definitions

@flo-renaud flo-renaud closed this Jan 21, 2021
@flo-renaud
Copy link
Contributor

@mrizwan93 a manual backport is required for ipa-4-9 branch (likely because of the yaml files that have different names), can you do it? Thanks

@mrizwan93
Copy link
Contributor Author

@flo-renaud Thanks, backport PR raised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ack Pull Request approved, can be merged ipa-4-9 Mark for backport to ipa 4.9 pushed Pull Request has already been pushed
Projects
None yet
4 participants