-
Notifications
You must be signed in to change notification settings - Fork 332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ipatests: Test if server setup without dns uninstall properly #5443
Conversation
@mrizwan93 |
ba1c172
to
245e418
Compare
ddfb3cf
to
48838c4
Compare
@@ -68,7 +68,7 @@ jobs: | |||
class: RunPytest | |||
args: | |||
build_url: '{fedora-latest/build_url}' | |||
test_suite: test_integration/test_REPLACEME.py | |||
test_suite: test_integration/test_uninstall.py::UninstallWithoutDNS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a typo in the temp commit, should be:
test_suite: test_integration/test_uninstall.py::TestUninstallWithoutDNS
LGTM, temp commit can be removed. |
Thanks @kaleemsiddiqu temp commit results |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mrizwan93
as there is a new test file, you need to add job definitions in ipatests/prci_definitions/*.yaml. No need to add the new test in gating.yaml, nightly_latest_pki.yaml or nightly_latest_389ds.yaml but the test needs to be defined in the other files.
IPA server uninstall was failing if dns was not setup. This test check if it uninstalls propelry. related: https://pagure.io/freeipa/issue/8630 Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
Signed-off-by: Mohammad Rizwan <myusuf@redhat.com>
@mrizwan93 thanks for the update, the nightly definitions LGTM. |
@mrizwan93 a manual backport is required for ipa-4-9 branch (likely because of the yaml files that have different names), can you do it? Thanks |
@flo-renaud Thanks, backport PR raised. |
IPA server uninstall was failing if dns was not setup.
This test check if it uninstalls propelry.
related: https://pagure.io/freeipa/issue/8630
Signed-off-by: Mohammad Rizwan myusuf@redhat.com